Skip to content

feat: Option to change tag click behaviour #945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 6, 2025
Merged

feat: Option to change tag click behaviour #945

merged 5 commits into from
Jun 6, 2025

Conversation

@Computerdores
Copy link
Collaborator

@Computerdores Computerdores commented Jun 4, 2025

Summary

Resolves #944.

Tasks Completed

  • Platforms Tested:
    • Windows x86
    • Windows ARM
    • macOS x86
    • macOS ARM
    • Linux x86
    • Linux ARM
  • Tested For:
    • Basic functionality
    • PyInstaller executable

@Computerdores Computerdores moved this to 🏓 Ready for Review in TagStudio Development Jun 4, 2025
@Computerdores Computerdores added Type: Enhancement New feature or request Type: UI/UX User interface and/or user experience Status: Review Needed A review of this is needed labels Jun 4, 2025
@Computerdores Computerdores mentioned this pull request Jun 5, 2025
Closed
3 tasks
@CyanVoxel
Copy link
Member

CyanVoxel commented Jun 5, 2025

Looks good! Just needs some base strings in en.json and I think this should be good to go. Other than that, it would be ideal if the "Add to Search" functionality didn't add tags to searches they already exist in (thus killing the search), but I understand that since it's using a string manipulation approach that this would be a bit messy to tack that onto.

@CyanVoxel CyanVoxel moved this from 🏓 Ready for Review to 👀 In review in TagStudio Development Jun 5, 2025
@CyanVoxel CyanVoxel removed the Status: Review Needed A review of this is needed label Jun 5, 2025
@Computerdores
Copy link
Collaborator Author

Computerdores commented Jun 5, 2025

Ok TIL that A AND A doesn't return anything that is definitely a bug.
As for the strings, I totally forgot to add those will do that really quick.

@Computerdores
Copy link
Collaborator Author

Computerdores commented Jun 5, 2025

I have added the missing strings and also found and fixed a bug because of which the settings dropdowns were always english even if the user set TS to be in some other language

@CyanVoxel CyanVoxel moved this from 👀 In review to 🍃 Pending Merge in TagStudio Development Jun 5, 2025
@CyanVoxel CyanVoxel added the Status: Mergeable The code is ready to be merged label Jun 5, 2025
@CyanVoxel CyanVoxel added this to the Alpha v9.5.3 milestone Jun 5, 2025
CyanVoxel
CyanVoxel approved these changes Jun 6, 2025
View reviewed changes
Copy link
Member

@CyanVoxel CyanVoxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your quick work on this!

@CyanVoxel CyanVoxel merged commit c100bab into TagStudioDev:main Jun 6, 2025
5 checks passed
@github-project-automation github-project-automation bot moved this from 🍃 Pending Merge to ✅ Done in TagStudio Development Jun 6, 2025
@Computerdores Computerdores deleted the 944-option-to-change-tag-click-behaviour branch July 6, 2025 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CyanVoxel CyanVoxel CyanVoxel approved these changes

Assignees

No one assigned

Labels

Status: Mergeable The code is ready to be merged Type: Enhancement New feature or request Type: UI/UX User interface and/or user experience

Projects

TagStudio Development
Status: ✅ Done

Milestone

Alpha v9.5.3

Development

Successfully merging this pull request may close these issues.

[Feature Request]: Option to change tag click behaviour

2 participants

@Computerdores @CyanVoxel